[PATCH] D37268: Invalidate symbolizer module list from dlopen/dlclose interceptors

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 13:58:53 PDT 2017


eugenis accepted this revision.
eugenis added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:5579
   void *res = REAL(dlopen)(filename, flag);
+  Symbolizer::GetOrInit()->InvalidateModuleList();
   COMMON_INTERCEPTOR_LIBRARY_LOADED(filename, res);
----------------
This would not spawn addr2line or llvm-symbolizer process right away?


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_libcdep.cc:185
     modules_fresh_ = false;
     return FindModuleForAddress(address);
   }
----------------
This recursion will be removed in the followup change, right?


https://reviews.llvm.org/D37268





More information about the llvm-commits mailing list