[llvm] r314123 - [ARM] Fix -Wdangling-else warning.

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 10:35:38 PDT 2017


Author: d0k
Date: Mon Sep 25 10:35:38 2017
New Revision: 314123

URL: http://llvm.org/viewvc/llvm-project?rev=314123&view=rev
Log:
[ARM] Fix -Wdangling-else warning.

A ternary is clearer here. No functionality change.

Modified:
    llvm/trunk/lib/Target/ARM/ARMBaseRegisterInfo.cpp

Modified: llvm/trunk/lib/Target/ARM/ARMBaseRegisterInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMBaseRegisterInfo.cpp?rev=314123&r1=314122&r2=314123&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMBaseRegisterInfo.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMBaseRegisterInfo.cpp Mon Sep 25 10:35:38 2017
@@ -94,10 +94,8 @@ ARMBaseRegisterInfo::getCalleeSavedRegs(
 
   if (STI.getTargetLowering()->supportSwiftError() &&
       F->getAttributes().hasAttrSomewhere(Attribute::SwiftError))
-    if (STI.isTargetDarwin())
-      return CSR_iOS_SwiftError_SaveList;
-    else
-      return CSR_AAPCS_SwiftError_SaveList;
+    return STI.isTargetDarwin() ? CSR_iOS_SwiftError_SaveList
+                                : CSR_AAPCS_SwiftError_SaveList;
 
   if (STI.isTargetDarwin() && F->getCallingConv() == CallingConv::CXX_FAST_TLS)
     return MF->getInfo<ARMFunctionInfo>()->isSplitCSR()
@@ -125,10 +123,8 @@ ARMBaseRegisterInfo::getCallPreservedMas
 
   if (STI.getTargetLowering()->supportSwiftError() &&
       MF.getFunction()->getAttributes().hasAttrSomewhere(Attribute::SwiftError))
-    if (STI.isTargetDarwin())
-      return CSR_iOS_SwiftError_RegMask;
-    else
-      return CSR_AAPCS_SwiftError_RegMask;
+    return STI.isTargetDarwin() ? CSR_iOS_SwiftError_RegMask
+                                : CSR_AAPCS_SwiftError_RegMask;
 
   if (STI.isTargetDarwin() && CC == CallingConv::CXX_FAST_TLS)
     return CSR_iOS_CXX_TLS_RegMask;




More information about the llvm-commits mailing list