[PATCH] D38224: Don't move llvm.localescape outside the entry block in the GCOV profiling pass

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:550-552
+      while (shouldKeepInEntry(It))
         ++It;
       EntryBlock.splitBasicBlock(It);
----------------
This problematically assumes that all the allocas, dbg.declare, and localescape are all in a contiguous block, but that's a pre-existing issue that you don't need to fix. In practice, clang inserts localescape after allocas.


https://reviews.llvm.org/D38224