[PATCH] D38133: [CGP] Make optimizeMemoryInst introduce a select/phi if it improves things

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 10:12:12 PDT 2017


john.brawn added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:4498
+    // Similar for select.
+    if (SelectInst *SI = dyn_cast<SelectInst>(V)) {
+      worklist.push_back(SI->getFalseValue());
----------------
reames wrote:
> I think the select handling can be separate from the rest of the patch and reviewed separately.  This should kick in even if the underlying addresses share the same addr mode.
> 
> Please do this to simply the review and increase the common code which can be shared between the two related patches in this area.
I've split this out into D38242.


Repository:
  rL LLVM

https://reviews.llvm.org/D38133





More information about the llvm-commits mailing list