[PATCH] D38135: [dwarfdump] Skip 'stripped' sections

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 09:04:43 PDT 2017


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Object/MachOObjectFile.cpp:1932
+bool MachOObjectFile::isSectionStripped(DataRefImpl Sec) const {
+  // When dsymutil generates the companion file, its strips all unnecessary
+  // sections (e.g. everything in the _TEXT segment) by omitting their body and
----------------
s/its/it/


================
Comment at: lib/Object/MachOObjectFile.cpp:1932
+bool MachOObjectFile::isSectionStripped(DataRefImpl Sec) const {
+  // When dsymutil generates the companion file, its strips all unnecessary
+  // sections (e.g. everything in the _TEXT segment) by omitting their body and
----------------
aprantl wrote:
> s/its/it/
I think it might be better to move the comment into the header so doxygen can pick it up.


https://reviews.llvm.org/D38135





More information about the llvm-commits mailing list