[PATCH] D38227: [Builtins] ARM: Fix assembling files in thumb mode.

[Manoj Gupta via Phabricator via llvm-commits]

manojgupta added inline comments.


================
Comment at: lib/builtins/arm/aeabi_cdcmp.S:54-56
+#elif defined(USE_THUMB_2)
+        mov ip, #APSR_C
+        msr CPSR_f, ip
----------------
Please review this change and the one below since I am not much of an ARM assembly expert.


================
Comment at: lib/builtins/arm/aeabi_memset.S:27
 
+        .p2align 2
 DEFINE_COMPILERRT_FUNCTION(__aeabi_memclr)
----------------
This was the only function I found without a .p2align. Please let me know if this change is not required.


https://reviews.llvm.org/D38227