[PATCH] D38133: [CGP] Make optimizeMemoryInst introduce a select/phi if it improves things

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 25 05:03:45 PDT 2017


reames added a comment.

In https://reviews.llvm.org/D38133#878598, @skatkov wrote:

> Does it makes sense for you to review it and extend with select support and other than base parts?


I will insist on collaboration here.  It doesn't have to be the case that we land either patch as currently structured; we could instead extract common functionality they can both build on.  We don't want to waste the time either of you have put into this, and as currently structured the two patches are conflicting.  That needs to change.


Repository:
  rL LLVM

https://reviews.llvm.org/D38133





More information about the llvm-commits mailing list