[PATCH] D37898: [TargetLowering] Correctly track NumFixedArgs field of CallLoweringInfo

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

Thanks for the heads-up. WebAssembly's current varargs calling convention does pass the fixed args in one way (via declared function arguments) and the non-fixed args in another way (in memory), so in the cases where NumFixedArgs was wrong we would have been doing the wrong thing. However wasm also typechecks all calls against the declared function signature, so any wrong cases would fail in obvious ways (a signature mismatch error at validation time for direct calls, and at runtime for indirect calls). So just making the behavior correct should be the right thing to do. Also we have explicitly promised that we don't have a stable ABI yet, so that helps too :D

So, LGTM.


https://reviews.llvm.org/D37898