[PATCH] D37898: [TargetLowering] Correctly track NumFixedArgs field of CallLoweringInfo

[Derek Schuff via llvm-commits]

phab seems down, but here's what I tried to add there:

Thanks for the heads-up. WebAssembly's current varargs calling convention
does pass the fixed args in one way (via declared function arguments) and
the non-fixed args in another way (in memory), so in the cases where
NumFixedArgs was wrong we would have been doing the wrong thing. However
wasm also typechecks all calls against the declared function signature, so
any wrong cases would fail in obvious ways (a signature mismatch error at
validation time for direct calls, and at runtime for indirect calls). So
just making the behavior correct should be the right thing to do. Also we
have explicitly promised that we don't have a stable ABI yet, so that helps
too :D


On Fri, Sep 22, 2017 at 11:23 AM Eli Friedman via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> efriedma added subscribers: sdardis, sunfish, jpienaar, efriedma.
> efriedma added a comment.
>
> x86, arm, and aarch64 have calling conventions which care whether a call
> is varargs, but not whether a particular argument is specified in the
> prototype.
>
> Some grepping shows that MIPS, WebAssembly and Lanai care about
> NumFixedArgs.
>
>
> https://reviews.llvm.org/D37898
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170922/9e90b653/attachment.html>