[PATCH] D38088: Fix out-of-order stepping behavior in programs with hoisted constants.

[Robinson, Paul via llvm-commits]

(re-adding llvm-commits)
If this is motivated by SPGO issues - should it be using mergeDebugLocations, then (& thus only changing the location if they come from different basic blocks)?

Well, you could consider it a merge of all the uses, but then it should also be merged with the insertion point, which is chosen to dominate the uses.  Intuitively it seemed unlikely this would ever produce a real debug location.  (Also, in a sense this is an artificially generated instruction and from that perspective having no source location is also appropriate.)
Do you want us to pursue the extra bookkeeping?  I'm having a hard time imagining this coming up in the wild (i.e., not convinced it's worth the effort, but you're a lot better at that than I am).
--paulr

https://reviews.llvm.org/D38088

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170922/0f94d409/attachment.html>