[PATCH] D37848: [ELF] - Dedupliсate FDEs correctly when two sections are ICFed

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 22 01:24:13 PDT 2017


grimar added a comment.

In https://reviews.llvm.org/D37848#878146, @ruiu wrote:

> I wonder if you really understood my point. What I was saying that, if two functions have different FDEs, we probably shouldn't merge these functions because merging them could change their behavior when exception is thrown. We are not talking about the current lld's or gold's behavior but what it should be. Are we on the same page?


Now - yes. 
I'll be happy to try to reimplement this patch to change how ICF handles sections with/without FDEs to most correct way then.


https://reviews.llvm.org/D37848





More information about the llvm-commits mailing list