[PATCH] D38102: [XRay] support conditional return on PPC.

[Tim Shen via Phabricator via llvm-commits]

timshen added inline comments.


================
Comment at: llvm/lib/CodeGen/XRayInstrumentation.cpp:37
 
+struct Option {
+  // Whether to emit PATCHABLE_TAIL_CALL.
----------------
dberris wrote:
> nit: Probably name this as `InstrumentationOptions`?
Done.


================
Comment at: llvm/lib/CodeGen/XRayInstrumentation.cpp:39
+  // Whether to emit PATCHABLE_TAIL_CALL.
+  bool HandleTailcall;
+
----------------
dberris wrote:
> Please provide a default value here, say `bool HandleTailCall = true;`?
I actually prefer not to, as the intention is to force the user to think about the choice to make. Providing default values make the user think less about the behaviors.

I disabled default constructor.


https://reviews.llvm.org/D38102