[PATCH] D23601: [TII] add new target hook isAdd

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 13:57:14 PDT 2017


MatzeB added a comment.

It would be great if someone could add more comments of what isAdd entails. All documentation in the current llvm code is a variation of `Is this instruction an add instruction?`/`\brief Return true if the instruction is an add instruction.`. Are there any requirements on which operands of the instruction are actually added together or hold the result? Can they be immediates and register operands, load from memory?

This flag seems to only be used on 2 hexagon instructions and it makes me wonder if it shouldn't rather have been a member function in HexagonInstrInfo.


Repository:
  rL LLVM

https://reviews.llvm.org/D23601





More information about the llvm-commits mailing list