[PATCH] D37740: [SelectionDAG] Pick correct frame index in LowerArguments

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 12:00:46 PDT 2017


bjope added a comment.

In https://reviews.llvm.org/D37740#877747, @rnk wrote:

> In https://reviews.llvm.org/D37740#877735, @aprantl wrote:
>
> > Seems ok to me.
> >  @rnk: was your concern addressed?
>
>
> Yeah, sorry I didn't say anything. My thoughts were along the lines of "yes, this code is complicated and hard to simplify. Bummer. :("


Thanks for the review! Hopefully we can come back and simplify this code in the future.


Repository:
  rL LLVM

https://reviews.llvm.org/D37740





More information about the llvm-commits mailing list