[PATCH] D38141: Annotate function parameters with attribute 'noescape'

Akira Hatanaka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 11:31:11 PDT 2017


ahatanak added a comment.

In https://reviews.llvm.org/D38141#877824, @kubamracek wrote:

> That's what we should do here.  Since the file includes dispatch.h, we should be able to just use the `DISPATCH_NOESCAPE` macro, which already uses `#if __has_attribute`.


OK, I'll use DISPATCH_NOESCAPE then.

In https://reviews.llvm.org/D38141#877876, @kubamracek wrote:

> So is this going to generally break sources which do the same as `tsan_libdispatch_mac.cc`?


Yes, clang will reject it with message "error: conflicting types for ...".


https://reviews.llvm.org/D38141





More information about the llvm-commits mailing list