[PATCH] D38137: [ELF] Simpler scheme for handling common symbols

ben via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 11:24:52 PDT 2017


bd1976llvm added a comment.

In https://reviews.llvm.org/D38137#877803, @ruiu wrote:

> First of all, could you read https://llvm.org/docs/CodingStandards.html and follow that style? One of the easiest way is to run clang-format-diff on your patch so that everything in your patch is formatted automatically.


What a mess! Thanks for reviewing the patch despite how unstylish it is.
I agree with all the points you raised - will update the patch.


https://reviews.llvm.org/D38137





More information about the llvm-commits mailing list