[PATCH] D38139: [scudo] Scudo thread specific data refactor, part 1

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 09:12:46 PDT 2017


cryptoad created this revision.
Herald added a subscriber: srhines.

We are going through an overhaul of Scudo's TSD, to allow for new platforms
to be integrated more easily, and make the code more sound.

This first part is mostly renaming, preferring some shorter names, correcting
some comments. I removed `getPrng` and `getAllocatorCache` to directly access
the members, there was not really any benefit to them (and it was suggested by
Dmitry in https://reviews.llvm.org/D37590).

The only functional change is in `scudo_tls_android.cpp`: we enforce bounds to
the `NumberOfTSDs` and most of the logic in `getTSDAndLockSlow` is skipped if we
only have 1 TSD.


https://reviews.llvm.org/D38139

Files:
  lib/scudo/scudo_allocator.cpp
  lib/scudo/scudo_tls.h
  lib/scudo/scudo_tls_android.cpp
  lib/scudo/scudo_tls_android.inc
  lib/scudo/scudo_tls_context_android.inc
  lib/scudo/scudo_tls_context_linux.inc
  lib/scudo/scudo_tls_linux.cpp
  lib/scudo/scudo_tls_linux.inc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38139.116203.patch
Type: text/x-patch
Size: 13675 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170921/89f0257e/attachment.bin>


More information about the llvm-commits mailing list