[PATCH] D38125: [dwarfdump] Add support for redirecting output to a file

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

LGTM with inline comments addressed.
Thanks!



================
Comment at: tools/llvm-dwarfdump/llvm-dwarfdump.cpp:134
+    OutputFilename("out-file", cl::init(""),
+                   cl::desc("Redirect output to the file specified"),
+                   cl::value_desc("filename"));
----------------
Not a nativer speaker, but IMO "to the specified file" sounds marginally better.


================
Comment at: tools/llvm-dwarfdump/llvm-dwarfdump.cpp:332
+    // Don't remove output file if we exit with an error.
+    OutputFile->keep();
+  }
----------------
I think this needs to come before error since error is noreturn?


Repository:
  rL LLVM

https://reviews.llvm.org/D38125