[PATCH] D37686: [DAG] Consolidating Instruction->SDNode Flags propagation in one class for better code management.

[Jatin Bhateja via Phabricator via llvm-commits]

jbhateja added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:666
+  // a given Value.
+  SDNode * getDAGNode(const Value *);
+
----------------
spatel wrote:
> spatel wrote:
> > RKSimon wrote:
> > > spatel wrote:
> > > > Formatting/spacing is non-standard here and below. Run clang-format?
> > > is this needed in this patch?
> > Same question as earlier (I don't think it was answered). 
> > 
> > Can we use the existing SelectionDAGBuilder::getValue() to get to the node's flags?
> Asking for the 3rd time: is this necessary?
 SelectionDAGBuilder::getValue() creates a new Values and puts it into a NodeMap if it does not exist and SelectionDAGBuilder::getDAGNode() check NodeMap and returns a DAG node only if it exists.


https://reviews.llvm.org/D37686