[PATCH] D37960: [mips] Fix relocation record format and ELF header for N32 ABI

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 02:26:52 PDT 2017


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with inline nit addressed.



================
Comment at: test/MC/Mips/elf_header.s:112
+# O32-NEXT:       EF_MIPS_ABI_O32 (0x1000)
+
+# MIPS2-NEXT:     EF_MIPS_ARCH_2  (0x10000000)
----------------
You've retained the N64 check prefix in the relevant tests, can you add N64-NOT: for the EF_MIPS_ABI2  / EF_MIPS_ABI_O32 / EF_MIPS32BITMODE flags?


Repository:
  rL LLVM

https://reviews.llvm.org/D37960





More information about the llvm-commits mailing list