[PATCH] D37971: [dwarfdump] Add verbose output for .debug-line section

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 21 02:21:40 PDT 2017


JDevlieghere marked 4 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: test/DebugInfo/MIR/X86/empty-inline.mir:7
 # CHECK: DW_TAG_subprogram
-# CHECK:	DW_AT_low_pc [DW_FORM_addr]	(0x0000000000000000)
+# CHECK:	DW_AT_low_pc {{.*}}(0x0000000000000000)
 # CHECK-NOT: DW_TAG
----------------
probinson wrote:
> JDevlieghere wrote:
> > dblaikie wrote:
> > > I don't think the {{.*}} is needed? Maybe - not sure how whitespace-ignorant FileCheck is by default.
> > AFAIK only leading and trailing whitespace is ignored. An additional benefit is that most of the lines won't have to be changed if we ever want to make the test verbose again. 
> I am pretty sure that FileCheck treats all whitespace as variable length, unless you tell it to be strict.
Seems like you were both right! I've updated the tests. 


https://reviews.llvm.org/D37971





More information about the llvm-commits mailing list