[PATCH] D38098: Removed platform-specific ifdefs from sanitizer_procmaps.h

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_procmaps.h:89
 # endif
+  MemoryMappingLayoutData *data_;
 };
----------------
Vurchin wrote:
> fjricci wrote:
> > Vurchin wrote:
> > > vitalybuka wrote:
> > > > Instead of dynamic allocation maybe just:
> > > > 
> > > > 
> > > > ```
> > > > #inlude <sanitizer_procmaps_linux.h>
> > > > #inlude <sanitizer_procmaps_mac.h>
> > > > ... 
> > > > MemoryMappingLayoutData data_;
> > > > ```
> > > So do you think I should create these two files?
> > I would lean towards just using sanitizer_mac.h, like you already did for sanitizer_linux.h, since it seems silly to create a header for just one struct. But will defer to @vitalybuka 
> Haha, alright, I also like that idea
sanitizer_mac.h and sanitizer_linux.h  are good as well


https://reviews.llvm.org/D38098