[PATCH] D38115: [lit/Win] Check if a path was found before attempting to use it.

[David L. Jones via Phabricator via llvm-commits]

dlj created this revision.
Herald added a subscriber: sanjoy.
Herald added a reviewer: modocache.

This appears to break some bots, when getToolsPath fails to find some or
all of the tools (for example, an incomplete GnuWin32 installation).


https://reviews.llvm.org/D38115

Files:
  utils/lit/lit/llvm/config.py


Index: utils/lit/lit/llvm/config.py
===================================================================
--- utils/lit/lit/llvm/config.py
+++ utils/lit/lit/llvm/config.py
@@ -27,7 +27,8 @@
             path = self.lit_config.getToolsPath(config.lit_tools_dir,
                                            config.environment['PATH'],
                                            ['cmp.exe', 'grep.exe', 'sed.exe'])
-            self.with_environment('PATH', path, append_path=True)
+            if path is not None:
+                self.with_environment('PATH', path, append_path=True)
             self.use_lit_shell = True
 
         # Choose between lit's internal shell pipeline runner and a real shell.  If


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38115.116130.patch
Type: text/x-patch
Size: 709 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170921/624f7398/attachment.bin>