[llvm] r313847 - [SelectionDAG] Replace a flag that can never be true with an assert.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 17:18:46 PDT 2017


Author: ctopper
Date: Wed Sep 20 17:18:46 2017
New Revision: 313847

URL: http://llvm.org/viewvc/llvm-project?rev=313847&view=rev
Log:
[SelectionDAG] Replace a flag that can never be true with an assert.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/TargetLowering.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/TargetLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/TargetLowering.cpp?rev=313847&r1=313846&r2=313847&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/TargetLowering.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/TargetLowering.cpp Wed Sep 20 17:18:46 2017
@@ -421,9 +421,8 @@ bool TargetLowering::ShrinkDemandedOp(SD
           Op.getOpcode(), dl, SmallVT,
           DAG.getNode(ISD::TRUNCATE, dl, SmallVT, Op.getOperand(0)),
           DAG.getNode(ISD::TRUNCATE, dl, SmallVT, Op.getOperand(1)));
-      bool NeedZext = DemandedSize > SmallVTBits;
-      SDValue Z = DAG.getNode(NeedZext ? ISD::ZERO_EXTEND : ISD::ANY_EXTEND,
-                              dl, Op.getValueType(), X);
+      assert(DemandedSize <= SmallVTBits && "Narrowed below demanded bits?");
+      SDValue Z = DAG.getNode(ISD::ANY_EXTEND, dl, Op.getValueType(), X);
       return TLO.CombineTo(Op, Z);
     }
   }




More information about the llvm-commits mailing list