[PATCH] D38102: [XRay] support conditional return on PPC.

[Dean Michael Berris via Phabricator via llvm-commits]

dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM for the instrumentation pass side (with a couple of suggestions).

I'll let @echristo decide on the AsmPrinter and MCInstLower implementations.



================
Comment at: llvm/lib/CodeGen/XRayInstrumentation.cpp:37
 
+struct Option {
+  // Whether to emit PATCHABLE_TAIL_CALL.
----------------
nit: Probably name this as `InstrumentationOptions`?


================
Comment at: llvm/lib/CodeGen/XRayInstrumentation.cpp:39
+  // Whether to emit PATCHABLE_TAIL_CALL.
+  bool HandleTailcall;
+
----------------
Please provide a default value here, say `bool HandleTailCall = true;`?


https://reviews.llvm.org/D38102