[PATCH] D38088: Fix out-of-order stepping behavior in programs with hoisted constants.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 16:34:49 PDT 2017


craig.topper added inline comments.


================
Comment at: lib/Transforms/Scalar/ConstantHoisting.cpp:745
              "All uses should be instructions.");
-      Base->setDebugLoc(cast<Instruction>(Base->user_back())->getDebugLoc());
+      Base->setDebugLoc(DebugLoc());
     }
----------------
This code now longer matches the comment. And the asserts are no longer required since they existed to ensure validity of the previous behavior.


https://reviews.llvm.org/D38088





More information about the llvm-commits mailing list