[PATCH] D38098: Removed platform-specific ifdefs from sanitizer_procmaps.h

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 15:01:54 PDT 2017


vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_procmaps.h:89
 # endif
+  MemoryMappingLayoutData *data_;
 };
----------------
Instead of dynamic allocation maybe just:


```
#inlude <sanitizer_procmaps_linux.h>
#inlude <sanitizer_procmaps_mac.h>
... 
MemoryMappingLayoutData data_;
```


================
Comment at: lib/sanitizer_common/sanitizer_procmaps_linux.cc:21
 
+  struct ProcSelfMapsBuff {
+    char *data;
----------------
missalingned


https://reviews.llvm.org/D38098





More information about the llvm-commits mailing list