[PATCH] D38099: Fix crashes with -fprofile-use + new pass manager in queens.c from the testsuite (bugzilla bug 33776)

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 14:50:18 PDT 2017


nemanjai added a comment.

> 3. Can you please explain the rationale behind this fix? I'm afraid it's just papering over the problem rather than solving it.

I am not at all sure how this is supposed to work, but it certainly seems messy to always do a NULL check before using ORE. Perhaps someone that really knows how this is supposed to work can comment on why there's a requirement that the ORE object be available in the cache (i.e. why we need to acquire it through `getCachedResult()` rather than `getResult()` and add it to the cache if it isn't already cached).


https://reviews.llvm.org/D38099





More information about the llvm-commits mailing list