[PATCH] D37760: [AMDGPU] do not generate .AMDGPU.config for amdpal os type

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:254
   MCContext &Context = getObjFileLowering().getContext();
-  if (!STM.isAmdHsaOS()) {
+  if (!STM.isAmdHsaOS() && !STM.isAmdPalOS()) {
     MCSectionELF *ConfigSection =
----------------
tpr wrote:
> arsenm wrote:
> > Probably should make this a positive check on is mesa (although that might be broken because I'm not sure mesa graphics ever fully switched to explicitly setting the triple)
> Yeah, I don't think that happens anywhere else for mesa, so I assume mesa doesn't set the os type in the triple. So can I leave this as it is?
Sure. Add a FIXME to make this an explicit mesa check


https://reviews.llvm.org/D37760