[PATCH] D38091: [TableGen] Tidy up CodeGenRegisters

[Matthias Braun via Phabricator via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: utils/TableGen/CodeGenRegisters.cpp:100
     SmallVector<CodeGenSubRegIndex*, 8> IdxParts;
-    for (unsigned i = 0, e = Parts.size(); i != e; ++i)
-      IdxParts.push_back(RegBank.getSubRegIdx(Parts[i]));
+    for (Record *Part: Parts)
+      IdxParts.push_back(RegBank.getSubRegIdx(Part));
----------------
Space before `:`


================
Comment at: utils/TableGen/CodeGenRegisters.cpp:192
   std::vector<Record*> Aliases = TheDef->getValueAsListOfDefs("Aliases");
-  for (unsigned i = 0, e = Aliases.size(); i != e; ++i) {
-    CodeGenRegister *Reg = RegBank.getReg(Aliases[i]);
+  for (Record *Alias: Aliases) {
+    CodeGenRegister *Reg = RegBank.getReg(Alias);
----------------
ditto


https://reviews.llvm.org/D38091