[PATCH] D37631: [libFuzzer] Support using libc++

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 11:32:30 PDT 2017


vitalybuka added a comment.

So actually if LLVM_ENABLE_LIBCXX=NO it already builds libfuzzer with libc++. There are issues with tests. We need to add --stdlib=libc++ there and maybe rpath.

> After thinking about it a bit more, I think `LLVM_ENABLE_LIBCXX` is fine for this purpose. The only question is whether you want to have separate toggle, e.g. for testing? Maybe we could keep the separate option but set `LLVM_ENABLE_LIBCXX` as its default value?

We should not test different variations of cmake flags and environments using cmake itself. This can get complicated very quickly.
Unless we are going to ship both fuzzer versions. Are we?

We have tests and we can just make them work with any value of  LLVM_ENABLE_LIBCXX. 
Then we just add another step into build bot config.
WDYT?


Repository:
  rL LLVM

https://reviews.llvm.org/D37631





More information about the llvm-commits mailing list