[PATCH] D38055: Tighten the invariants around LoopBase::invalidate

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added inline comments.


================
Comment at: llvm/trunk/include/llvm/Transforms/Scalar/LoopPassManager.h:170
+    assert(&L == CurrentL ||
+           CurrentL->contains(&L) && "Cannot delete a loop outside of the "
                                      "subloop tree currently being processed.");
----------------
sberg wrote:
> there's parentheses missing around the || here, right?
Since the string evaluates to true, this shouldn't matter -- "(A || B) && True" == "(A || B)" == "A || (B && True)".

Is this causing a warning on some compiler?  If so, let me know and I'll fix it (or feel free to directly commit a fix yourself).


Repository:
  rL LLVM

https://reviews.llvm.org/D38055