[PATCH] D37328: [mips] Reordering callseq* nodes to be linear

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 06:22:12 PDT 2017


sdardis added inline comments.


================
Comment at: test/CodeGen/Mips/callseq_order.ll:1-8
+; RUN: llc -mtriple=mipsel-linux-gnu -mcpu=mips32 -o /dev/null \
+; RUN:     -debug-only=isel %s 2>&1 | FileCheck %s
+; RUN: llc -mtriple=mips64el-linux-gnu -mcpu=mips64 -o /dev/null \
+; RUN:     -debug-only=isel %s 2>&1 | FileCheck %s
+; RUN: llc -mtriple=mips-linux-gnu -mcpu=mips32 -o /dev/null \
+; RUN:     -debug-only=isel %s 2>&1 | FileCheck %s
+; RUN: llc -mtriple=mips64-linux-gnu -mcpu=mips64 -o /dev/null \
----------------
Add  -verify-machineinstrs to these llc commands.


================
Comment at: test/CodeGen/Mips/callseq_order.ll:1-8
+; RUN: llc -mtriple=mipsel-linux-gnu -mcpu=mips32 -o /dev/null \
+; RUN:     -debug-only=isel %s 2>&1 | FileCheck %s
+; RUN: llc -mtriple=mips64el-linux-gnu -mcpu=mips64 -o /dev/null \
+; RUN:     -debug-only=isel %s 2>&1 | FileCheck %s
+; RUN: llc -mtriple=mips-linux-gnu -mcpu=mips32 -o /dev/null \
+; RUN:     -debug-only=isel %s 2>&1 | FileCheck %s
+; RUN: llc -mtriple=mips64-linux-gnu -mcpu=mips64 -o /dev/null \
----------------
sdardis wrote:
> Add  -verify-machineinstrs to these llc commands.
These can have -stop-before=expand-isel-pseudos to terminate llc early.


================
Comment at: test/CodeGen/Mips/callseq_order.ll:15
+
+; Function Attrs: noinline nounwind optnone
+define void @foo1() #0 {
----------------
This and the one below can be removed.


================
Comment at: test/CodeGen/Mips/callseq_order.ll:16
+; Function Attrs: noinline nounwind optnone
+define void @foo1() #0 {
+entry:
----------------
The #0 and the #1s below can be removed.


Repository:
  rL LLVM

https://reviews.llvm.org/D37328





More information about the llvm-commits mailing list