[PATCH] D38055: Tighten the invariants around LoopBase::invalidate

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 18:58:46 PDT 2017


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

Generally looks good. Description should likely be updated to reflect changes made during review. Feel free to submit!



================
Comment at: include/llvm/Transforms/Scalar/LoopPassManager.h:169
     LAM.clear(L);
-    assert(CurrentL->contains(&L) && "Cannot delete a loop outside of the "
+    assert(&L == CurrentL ||
+           CurrentL->contains(&L) && "Cannot delete a loop outside of the "
----------------
This seems like an unrelated change? (doesn't seem bad...)


https://reviews.llvm.org/D38055





More information about the llvm-commits mailing list