[lld] r313699 - [COFF] Check for sections larger than 4 GiB

[Shoaib Meenai via llvm-commits]

Author: smeenai
Date: Tue Sep 19 16:58:05 2017
New Revision: 313699

URL: http://llvm.org/viewvc/llvm-project?rev=313699&view=rev
Log:
[COFF] Check for sections larger than 4 GiB

Sections are limited to 4 GiB. Error out early if a section exceeds this
size, rather than overflowing the section size and getting confusing
assertion failures/segfaults later.

Differential Revision: https://reviews.llvm.org/D38005

Added:
    lld/trunk/test/COFF/section-size.s
Modified:
    lld/trunk/COFF/Driver.cpp
    lld/trunk/COFF/Writer.cpp

Modified: lld/trunk/COFF/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Driver.cpp?rev=313699&r1=313698&r2=313699&view=diff
==============================================================================
--- lld/trunk/COFF/Driver.cpp (original)
+++ lld/trunk/COFF/Driver.cpp Tue Sep 19 16:58:05 2017
@@ -1236,6 +1236,9 @@ void LinkerDriver::link(ArrayRef<const c
   // Write the result.
   writeResult();
 
+  if (ErrorCount)
+    return;
+
   // Call exit to avoid calling destructors.
   exit(0);
 }

Modified: lld/trunk/COFF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Writer.cpp?rev=313699&r1=313698&r2=313699&view=diff
==============================================================================
--- lld/trunk/COFF/Writer.cpp (original)
+++ lld/trunk/COFF/Writer.cpp Tue Sep 19 16:58:05 2017
@@ -187,6 +187,8 @@ void OutputSection::addChunk(Chunk *C) {
   C->setRVA(Off);
   C->OutputSectionOff = Off;
   Off += C->getSize();
+  if (Off > UINT32_MAX)
+    error("section larger than 4 GiB: " + Name);
   Header.VirtualSize = Off;
   if (C->hasData())
     Header.SizeOfRawData = alignTo(Off, SectorSize);

Added: lld/trunk/test/COFF/section-size.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/section-size.s?rev=313699&view=auto
==============================================================================
--- lld/trunk/test/COFF/section-size.s (added)
+++ lld/trunk/test/COFF/section-size.s Tue Sep 19 16:58:05 2017
@@ -0,0 +1,14 @@
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-windows-msvc %s -o %tmain.obj
+# RUN: echo '.lcomm s, 0x80000000' | llvm-mc -filetype=obj -triple=x86_64-windows-msvc -o %t1.obj
+# RUN: cp %t1.obj %t2.obj
+# RUN: echo '.lcomm s, 0xffffffff' | llvm-mc -filetype=obj -triple=x86_64-windows-msvc -o %t3.obj
+
+# Run: lld-link -entry:main %tmain.obj %t3.obj -out:%t.exe
+
+# RUN: not lld-link -entry:main %tmain.obj %t1.obj %t2.obj -out:%t.exe 2>&1 | FileCheck %s
+# CHECK: error: section larger than 4 GiB: .bss
+
+.globl main
+main:
+	retq