[PATCH] D37747: [MIPS] Fix PLT entries generation in case of linking regular and microMIPS code

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 16:49:45 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Arch/MipsArchTree.cpp:296
+  if (!Config->MipsEFlags) {
+    switch (Config->EKind) {
+    case ELF32LEKind:
----------------
I'd avoid dispatching based on Config->EKind. Can you initialize Config->EKind after all object files are ready?


Repository:
  rL LLVM

https://reviews.llvm.org/D37747





More information about the llvm-commits mailing list