[PATCH] D37957: [TableGen] Some simple optimizations to TableGen execution time

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:180
+  for (unsigned M : Modes)
+    OS << ' ' << getModeName(M) << ':';
+  OS << " }";
----------------
You still need to print the contents of the type set.  Something like:

```
for (unsigned M : Modes) {
  OS << ' ' << getModeName() << ':';
  writeToStream(get(M), OS);
}
```


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:3823
   if (N->isLeaf()) {
     if (isa<DefInit>(N->getLeafValue()))
       DepMap[N->getName()]++;
----------------
Make it `if (N->hasName() && isa<DefInit>(N->getLeafValue()))`.  This will avoid the assertion.


https://reviews.llvm.org/D37957