[PATCH] D36637: Import all inlined indirect call targets for SamplePGO.

[Dehao Chen via Phabricator via llvm-commits]

danielcdh marked an inline comment as done.
danielcdh added inline comments.


================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:734
       if (!CalledFunction || !CalledFunction->getSubprogram()) {
-        findCalleeFunctionSamples(*I)->findImportedFunctions(
-            ImportGUIDs, F.getParent(),
-            Samples->getTotalSamples() * SampleProfileHotThreshold / 100);
+        for (const FunctionSamples *FS : findIndirectCallFunctionSamples(*I))
+          FS->findImportedFunctions(
----------------
tejohnson wrote:
> I'm not really following the flow of what is supposed to happen here. I see that the earlier code already does an iteration over findIndirectCallFunctionSamples - can/should this be combined with that?
I'm planning to do that in a separate patch, in which I'll also move the InlineFunction call inside the loop too.


https://reviews.llvm.org/D36637