[PATCH] D37848: [ELF] - Dedupliсate FDEs correctly when two sections are ICFed

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

You are saying that it is not correct to merge a .text section with other .text section if one has an FDE and the other doesn't. But you are also saying that we should merge two .text sections if both have FDEs even if their FDE contents are different. These two statements does not sound consistent to me. I don't think I'm convinced.

If you are saying that checking existence of FDEs is enough, can you argue why that is enough? If not, you could write code to demonstrate a problem (I guess you could write code that uses exceptions and behaves differently when two sections are merged by ICF) so that we can fix it. I don't think this patch fixes a real problem.


https://reviews.llvm.org/D37848