[PATCH] D38010: lit.py: Allow configs and local configs to have a setup_script entry

Jordan Rose via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 11:33:49 PDT 2017


jordan_rose added a comment.

> Actually, I guess I'm a bit confused. What is this solving that you can't already do in a local config? Couldn't you just embed the stuff you want to execute in the local config?

I felt uncomfortable making the local config files actually have side effects, but really I want to follow up with this by moving the setup tasks into the parallel processing as actual dependencies. This is just the first iteration of the feature. If you think that's not a good direction, though, we could go with one of the other options.

(This also allows for the inheritance of setup logic into subdirectories, but that's not a critical feature for my use case, and indeed it's likely unexpected in many cases.)


Repository:
  rL LLVM

https://reviews.llvm.org/D38010





More information about the llvm-commits mailing list