[PATCH] D38008: [llvm-objcopy] Refactor code to include initialize method
Jake Ehrlich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 19 11:05:29 PDT 2017
jakehehrlich added a comment.
In https://reviews.llvm.org/D38008#874894, @jhenderson wrote:
> Just to point out, there's no diff context here! Aside from that, the overall change here looks good. I'm slightly surprised to see the SectionTable being copied everywhere, as I'd expect there to only be one, but I guess it doesn't matter since it's just a wrapper around a reference to an array of pointers.
My intent was for it to be a lightly copyable type like ArrayRef is. Maybe I could call it "SectionTableRef" to clarify this? That way it follows the way StringRef and ArrayRef are used.
Repository:
rL LLVM
https://reviews.llvm.org/D38008
More information about the llvm-commits
mailing list