[PATCH] D37483: AMDGPU: AMDPAL scratch buffer support

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 11:01:42 PDT 2017


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:899
+    unsigned Rsrc2Val = 0;
     if (STM.isVGPRSpillingEnabled(*MF.getFunction())) {
       OutStreamer->EmitIntValue(R_0286E8_SPI_TMPRING_SIZE, 4);
----------------
This looks like it's already here, but while you're here can you remove this check in a separate patch?


https://reviews.llvm.org/D37483





More information about the llvm-commits mailing list