[PATCH] D38022: [X86] Convert X86ISD::SELECT to ISD::VSELECT just before instruction selection to avoid duplicate patterns

Elena Demikhovsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 00:26:06 PDT 2017


delena added a comment.

Yes, I saw this comment. We create a custom node in order to avoid an additional "entrance" to LowerSELECT(), right?
In general, this approach is generic - create a custom node to stop the lowering process.
If we'll keep a table of custom-to-common last-minute replacement, it'd be, probably, more robust.
It may be implemented later.

X86select node is not used any more, it can be removed from td patterns.


https://reviews.llvm.org/D38022





More information about the llvm-commits mailing list