[PATCH] D38010: lit.py: Allow configs and local configs to have a setup_script entry

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 20:26:55 PDT 2017


zturner added a comment.

Why not just have `lit.setup-folder.cfg` similar to how we have `lit.local.cfg`?

Also, what about folder-level teardown?  Would it instead be better to have the setup script provide an `init` and `teardown` function that get run at the beginning an end?



================
Comment at: utils/lit/tests/Inputs/setup-script/subdir-custom/lit.local.cfg:1
+config.setup_script = 'Inputs/custom.sh'
----------------
Can you make this not be a shell script?  This is essentially saying "This test doesn't work on Windows" when there's no particular reason why it shouldn't


Repository:
  rL LLVM

https://reviews.llvm.org/D38010





More information about the llvm-commits mailing list