[PATCH] D38005: [COFF] Check for sections larger than 4 GiB

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 17:37:09 PDT 2017


ruiu added inline comments.


================
Comment at: COFF/Writer.cpp:191
+  if (Off > UINT32_MAX)
+    fatal("section larger than 4 GiB: " + Name);
   Header.VirtualSize = Off;
----------------
Can you use errro() instead? We use fatal() only for reporting corrupted input files. Files with too large sections are not technically corrupted.


https://reviews.llvm.org/D38005





More information about the llvm-commits mailing list