[PATCH] D37993: [ThinLTO/gold] Implement ThinLTO cache pruning support

Yi Kong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 17:24:30 PDT 2017


kongyi added inline comments.


================
Comment at: llvm/trunk/tools/gold/gold-plugin.cpp:229
+    } else if (opt.startswith("cache-policy=")) {
+      cache_policy = opt.substr(strlen("cache-policy="));
     } else if (opt.size() == 2 && opt[0] == 'O') {
----------------
mehdi_amini wrote:
> Did you consider using the same option name as lld for consistency?
> (i.e. why diverging when unnecessary)
I named this to be consistent with gold plugin's name for cache directory, "cache-dir". 


Repository:
  rL LLVM

https://reviews.llvm.org/D37993





More information about the llvm-commits mailing list