[PATCH] D37887: AMDGPU: Run internalize symbols at -O0

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:326
+    if (F->isDeclaration() || AMDGPU::isEntryFunctionCC(F->getCallingConv()))
+      return true;
+  }
----------------
rampitec wrote:
> arsenm wrote:
> > rampitec wrote:
> > > arsenm wrote:
> > > > rampitec wrote:
> > > > > Looks like it changes original logic. All functions were internalized except for declarations and kernels.
> > > > It's the same, also no tests fail
> > > If a function is called and not declaration it used to be internalized, with this change it will not.
> > Yes it is. This is the reason for doing this and is the func_used test I added
> Then what happens if function is finally inlined and no calls left? I suppose it will remain in the object, which is not we really want. 
There is no change here in behavior from what was here before other than also internalizing at -O0. Regardless of whether the function is used or not it is internalized


https://reviews.llvm.org/D37887