[PATCH] D37887: AMDGPU: Run internalize symbols at -O0

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 14:40:28 PDT 2017


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:326
+    if (F->isDeclaration() || AMDGPU::isEntryFunctionCC(F->getCallingConv()))
+      return true;
+  }
----------------
rampitec wrote:
> arsenm wrote:
> > rampitec wrote:
> > > Looks like it changes original logic. All functions were internalized except for declarations and kernels.
> > It's the same, also no tests fail
> If a function is called and not declaration it used to be internalized, with this change it will not.
Yes it is. This is the reason for doing this and is the func_used test I added


https://reviews.llvm.org/D37887





More information about the llvm-commits mailing list