[llvm] r313571 - [gcov] Emit errors when opening the notes file fails

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 14:31:48 PDT 2017


Author: rnk
Date: Mon Sep 18 14:31:48 2017
New Revision: 313571

URL: http://llvm.org/viewvc/llvm-project?rev=313571&view=rev
Log:
[gcov] Emit errors when opening the notes file fails

No time to write a test case, on to the next bug. =P

Discovered while investigating PR34659

Modified:
    llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp

Modified: llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp?rev=313571&r1=313570&r2=313571&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp (original)
+++ llvm/trunk/lib/Transforms/Instrumentation/GCOVProfiling.cpp Mon Sep 18 14:31:48 2017
@@ -519,6 +519,12 @@ void GCOVProfiler::emitProfileNotes() {
 
     std::error_code EC;
     raw_fd_ostream out(mangleName(CU, GCovFileType::GCNO), EC, sys::fs::F_None);
+    if (EC) {
+      Ctx->emitError(Twine("failed to open coverage notes file for writing: ") +
+                     EC.message());
+      continue;
+    }
+
     std::string EdgeDestinations;
 
     unsigned FunctionIdent = 0;




More information about the llvm-commits mailing list