[PATCH] D37996: [LoopInfo] Make LoopBase and Loop destructors non-public

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy created this revision.
Herald added subscribers: mcrosier, mehdi_amini.

See comment for why I think this is a good idea.

This change also:

- Removes an SCEV test case.  The SCEV test was not testing anything useful (most of it was `#if 0` ed out) and it would need to be updated to deal with a private ~Loop::Loop.
- Updates the loop pass manager test case to deal with a private ~Loop::Loop.
- Renames markAsRemoved to markAsErased to contrast with removeLoop, via the usual remove vs. erase idiom we already have for instructions and basic blocks.


https://reviews.llvm.org/D37996

Files:
  include/llvm/Analysis/LoopInfo.h
  lib/Analysis/LoopInfo.cpp
  lib/Transforms/IPO/LoopExtractor.cpp
  lib/Transforms/Scalar/LoopDeletion.cpp
  lib/Transforms/Utils/LoopUnroll.cpp
  unittests/Analysis/ScalarEvolutionTest.cpp
  unittests/Transforms/Scalar/LoopPassManagerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37996.115718.patch
Type: text/x-patch
Size: 16599 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170918/c1da5b48/attachment.bin>